-
-
Notifications
You must be signed in to change notification settings - Fork 197
feat: config
option
#5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config
option
#5554
Conversation
to set custom `nativescript.config` file name (relative, absolute, with or without .ts or .js) read `ignoredNativeDependencies` from `nativescript.config``nativescript.config`
Interesting side-effect of passing With webpack5, we require the CLI as a library and expose it through the Utils - but since the spawned webpack process now has Workaround is to splice/delete the |
add more tests
@rigor789 would nt it be simpler to rename this option ? Like nconfig maybe . |
Did some tweaking with both the CLI and the webpack bin to handle this case correctly. A small issue I need to fix is the config lookup - right now it will set all 3 paths to the resolved config ( |
TODO: Add |
to set custom
nativescript.config
file name (relative, absolute, with or without .ts or .js)read
ignoredNativeDependencies
fromnativescript.config``nativescript.config
I added a test. What is weird to me is that some tests are failing.But i cant see how they could pass, like this one https://github.com/farfromrefug/nativescript-cli/blob/cdf912ecdbd01c34ab405df2e9e39268f982d71f/test/tools/node-modules/node-modules-dependencies-builder.ts#L536